Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: centralize version number on package #342

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Nov 13, 2024

Acceptance Criteria

  • All code paths that require the version number should fetch if from the package.json directly
  • The check_version script should validate both application version numbers from the lockfile

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Nov 13, 2024
@tuliomir tuliomir marked this pull request as ready for review November 22, 2024 16:41
@tuliomir tuliomir requested a review from r4mmer as a code owner November 22, 2024 16:41
@tuliomir tuliomir requested a review from luislhl November 22, 2024 16:42
luislhl
luislhl previously approved these changes Nov 22, 2024
@tuliomir tuliomir force-pushed the refactor/centralize-versions branch from 71140b2 to 548551b Compare November 22, 2024 19:34
@tuliomir tuliomir changed the base branch from dev to master November 22, 2024 19:34
@tuliomir tuliomir merged commit 54599f3 into master Nov 25, 2024
@tuliomir tuliomir deleted the refactor/centralize-versions branch November 25, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants