Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Dashboard to functional component #296

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Aug 22, 2024

Acceptance Criteria

  • The landing page DashboardTx.js should be refactored to functional component

Notes

The order of the functions was changed and some of the functions were inlined to reduce the amount of memoing needed. Due to this, the diff became hard to read. I recommend going directly to the file itself and comparing with how it was before.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir requested a review from andreabadesso August 22, 2024 03:18
@tuliomir tuliomir self-assigned this Aug 22, 2024
@tuliomir tuliomir requested a review from r4mmer as a code owner August 22, 2024 03:18
@tuliomir tuliomir merged commit b7fc33e into dev Aug 22, 2024
1 check passed
@tuliomir tuliomir deleted the refactor/dashboard-functional branch August 22, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants