style: Manual lint fixes #294
Conversation
| @@ -27,6 +27,7 @@ const addressApi = { | |||
| if (res && res.data) { | |||
| return res.data; | |||
| } | |||
| return undefined; | |||
There was a problem hiding this comment.
| return undefined; | |
| return; |
Would this also work?
There was a problem hiding this comment.
It wouldn't: removing the explicit undefined raises an error about an unnecessary return on the last line of the function, and removing the return breaks the consistent-return lint rule that I intended to fix in the first time.
Maybe we can find a better solution at another time, but for now I'd rather not play with code logic.
src/api/customAxiosInstance.js
Outdated
| * @param {number} timeout Timeout in milliseconds for the request | ||
| * @param {number} [_timeout] Timeout in milliseconds for the request | ||
| */ | ||
| const createRequestInstance = (resolve, timeout) => { | ||
| const createRequestInstance = (resolve, _timeout) => { |
There was a problem hiding this comment.
suggestion(if-minor): Should we remove timeout?
If its not used we could just remove this argument, right?
There was a problem hiding this comment.
Good point. Removed on dcadfa5
tuliomir
force-pushed
the
style/lint-fixes
branch
from
f38cf8e to
f631cec
Compare
tuliomir
force-pushed
the
style/lint-fixes
branch
from
f631cec to
dcadfa5
Compare
| }) | ||
| .catch(error => { | ||
| .catch(_error => { |
There was a problem hiding this comment.
can't you do:
| .catch(_error => { | |
| .catch(() => { |
?
There was a problem hiding this comment.
I'd rather keep the variable, so that we feel more inclined to properly handle these errors in the future
Acceptance Criteria
Security Checklist