Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blueprint code to the blueprint detail screen #293

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

pedroferreira1
Copy link
Member

@pedroferreira1 pedroferreira1 commented Aug 19, 2024

Acceptance Criteria

  • We must show the blueprint source code in the blueprint detail screen.

Note I: I decided to install a package to highlight the code because the UI is improved a lot, the package is extensively used, and the explorer is not a code as critical as the wallet in terms of handling sensitive data.

Note II: it needs a new API in the nano hathor core (https://github.com/HathorNetwork/nano-hathor-core/pull/96) and the corresponding API in the explorer service (HathorNetwork/hathor-explorer-service#333)

Blueprint.code.mov

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Aug 19, 2024
@pedroferreira1 pedroferreira1 requested a review from r4mmer as a code owner August 19, 2024 12:58
@pedroferreira1 pedroferreira1 force-pushed the feat/add-blueprint-source-code branch from c74a38c to 1ffaaea Compare August 20, 2024 02:47
tuliomir
tuliomir previously approved these changes Aug 20, 2024
r4mmer
r4mmer previously approved these changes Aug 20, 2024
@pedroferreira1 pedroferreira1 dismissed stale reviews from r4mmer and tuliomir via 40aba48 August 20, 2024 17:42
@pedroferreira1 pedroferreira1 merged commit d732268 into dev Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants