-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix v0.19.0 deploy bugs #275
Conversation
src/components/Navigation.js
Outdated
class Navigation extends React.Component { | ||
constructor(props) { | ||
super(props); | ||
function Navigation(props) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking): I'd suggest making each of the props explicit, to make it clear what must be passed to this component.
function Navigation(props) { | |
function Navigation({ history }) { |
In this specific case, making history
explicit will allow us easily modify it to use the following syntax as soon as we upgrade react-router-dom
to v5.x
:
import { useHistory } from "react-router-dom";
function Navigation() {
const history = useHistory();
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 05763f6
Description
TypeError: axios.create is not a function
It's still unclear why this stopped working in this release but using
import
instead ofrequire
fixes the bug. 8cabe6fThe method
useFlag
can't be used inside of class component. 34f4e6fAcceptance Criteria
import
instead ofrequire
for axios.Navigation
component to a function.Security Checklist