Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changes to use wallet-lib v1.1.0 #252

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

pedroferreira1
Copy link
Member

@pedroferreira1 pedroferreira1 commented Dec 7, 2023

Acceptance Criteria

  • Bump lib version to the latest (v1.1.0)
    • The previous lib version was really old and many lib dependencies have changed. Because of that, the package-lock.json update was not easy, then I decided to also fix the versions of all dependencies in the package.json with the ones from the package-lock.json and run a full update in the package-lock.json file.
  • Update code for the new lib methods

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 self-assigned this Dec 7, 2023
@pedroferreira1 pedroferreira1 changed the title refactor: changes to use the new lib version refactor: changes to use wallet-lib v1.1.0 Jan 23, 2024
@pedroferreira1 pedroferreira1 force-pushed the refactor/new-lib-version branch from 091259c to d1d07d7 Compare January 23, 2024 22:21
@pedroferreira1 pedroferreira1 merged commit 151ab89 into dev Feb 6, 2024
1 check passed
@pedroferreira1 pedroferreira1 deleted the refactor/new-lib-version branch February 6, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants