feat: truncate children in tx detail API to return at most 100 elements #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luislhl
approved these changes
Oct 23, 2024
r4mmer
reviewed
Oct 23, 2024
handlers/node_api.py
Outdated
| # service we will truncate it and return only the latest 100 to show in the UI | ||
| # (it might even be more than we should, maybe we should paginate in the future) | ||
| if 'meta' in response and 'children' in response['meta']: | ||
| response['meta']['children'] = response['meta']['children'][-100:] |
There was a problem hiding this comment.
suggestion: Move 100 to the config.
Suggested change
| response['meta']['children'] = response['meta']['children'][-100:] | |
| response['meta']['children'] = response['meta']['children'][-TX_DAG_CHILDREN_CUTOFF:] |
Or MAX_TX_CHILDREN.
handlers/node_api.py
Outdated
| # service we will truncate it and return only the latest 100 to show in the UI | ||
| # (it might even be more than we should, maybe we should paginate in the future) | ||
| if 'meta' in response and 'children' in response['meta']: | ||
| response['meta']['children'] = response['meta']['children'][-100:] |
There was a problem hiding this comment.
Personally I think we can be stricter with this.
We can just cap at 20 instead.
There was a problem hiding this comment.
I agree with you, 20 should be more than enough. But we are currently showing everything, so I prefer keeping it as a "big" number for now, and we can reduce it in the future if we prefer.
r4mmer
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are networks with low quantity of transactions that remain for a long time without transactions. Because of that, the latest tx keeps being used by blocks as parent, so it list of children increases a lot. The explorer service lambda returns 502 for any response bigger than 6mb, so some transactions (https://explorer.testnet.hathor.network/transaction/00e161a6b0bee1781ea9300680913fb76fd0fac4acab527cd9626cc1514abdc9, for example) were not being loaded.
There's no reason for the UI to receive a list of 193k elements. We should paginate it, if we decide that it's important to show all of them. For now, we are truncating it and returning the latest 100 elements.
Acceptance Criteria
Security Checklist