Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update endpoints for blueprints APIs in hathor core #334

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pedroferreira1
Copy link
Member

Context

When I was creating a new API in the hathor core to get the blueprint source code, I had a discussion with @msbrogli about the best path for it. We ended up deciding to use /blueprint/source and, to keep consistency, we changed /blueprint (which returned the blueprint information) to /blueprint/info.

We decided to do it now that we don't have many clients using it and we can quickly update the lib and wallets with this new version.

Acceptance Criteria

  • Update blueprint info and blueprint source code endpoint URLs for the hathor core

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@pedroferreira1 pedroferreira1 requested a review from r4mmer as a code owner August 20, 2024 23:08
@pedroferreira1 pedroferreira1 self-assigned this Aug 20, 2024
@pedroferreira1 pedroferreira1 merged commit 37f10c3 into dev Aug 22, 2024
4 checks passed
@pedroferreira1 pedroferreira1 deleted the feat/update-blueprints-endpoints-hathor-core branch August 22, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants