Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update README.md with more information for deploying process #307

Merged
merged 2 commits into from
Feb 6, 2024
Merged

chore: update README.md with more information for deploying process #307

merged 2 commits into from
Feb 6, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Jan 18, 2024 •
edited
Loading

Acceptance Criteria

  • Update deploying information.

See README.md rendered.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack requested a review from r4mmer as a code owner January 18, 2024 18:52
@alexruzenhack alexruzenhack requested review from jansegre and luislhl and removed request for r4mmer January 18, 2024 18:52
@alexruzenhack alexruzenhack self-assigned this Jan 18, 2024
@alexruzenhack alexruzenhack requested review from pedroferreira1 and removed request for jansegre January 18, 2024 18:52
luislhl
luislhl reviewed Jan 19, 2024
View reviewed changes
README.md Outdated
@@ -14,10 +14,41 @@ If you add a new API, be careful to add ```request.header.origin``` as cacheKey,

## Deploying

Deploys are automated using Github Actions and Flux.
Deploys are automated using Github Actions and Flux in combination. A deployment is made for 3 environments: `dev`, `testnet` and `mainnet`; and 2 systems: lambdas and deamon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deamon -> daemon

@alexruzenhack alexruzenhack merged commit c166744 into dev Feb 6, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the chore/update-documentation branch February 6, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@luislhl luislhl luislhl approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexruzenhack @pedroferreira1 @luislhl