Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.12.1 #306

Merged
merged 2 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion domain/network/network.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class AggregatedNode:
uptime: float
state: NodeState
latest_timestamp: int
best_block: BlockInfo
best_block: Optional[BlockInfo]
entrypoints: List[str]
connected_peers: List[str]

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "hathor-explorer-service",
"version": "0.12.0",
"version": "0.12.1",
"description": "Hathor Explorer Service Serverless deps",
"dependencies": {
"@apidevtools/swagger-cli": "^4.0.4",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "hathor-explorer-service"
version = "0.12.0"
version = "0.12.1"
description = ""
authors = ["Hathor Labs <[email protected]>"]
license = "MIT"
Expand Down
25 changes: 24 additions & 1 deletion tests/unit/gateways/test_node_gateway.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pytest

from gateways.node_gateway import NodeGateway
from tests.fixtures.network_factory import NetworkFactory
from tests.fixtures.network_factory import AggregatedNodeFactory, NetworkFactory
from tests.fixtures.node_factory import NodeFactory


Expand Down Expand Up @@ -114,6 +114,29 @@ def test_get_network(self, cache_client):
assert result.peers[0].id == network.peers[0].id
assert result.nodes[0].id == network.nodes[0].id

def test_get_network_no_best_block(self, cache_client):
"""Test legacy node data stored in the cache."""

network = NetworkFactory(nodes=[AggregatedNodeFactory()])
network_dict = network.to_dict()

# remove best_block as property from each node
for each_node in network_dict.get("nodes"):
each_node.pop("best_block")

cache_client.get = MagicMock(return_value=network_dict)

gateway = NodeGateway(cache_client=cache_client)

result = gateway.get_network()

cache_client.get.assert_called_once_with("network", "v1")

assert result.peers[0].id == network.peers[0].id
assert result.nodes[0].id == network.nodes[0].id
assert hasattr(result.nodes[0], "best_block")
assert result.nodes[0].best_block is None

def test_get_no_network(self, cache_client):
cache_client.get = MagicMock(return_value=None)

Expand Down