Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sync-v2 peers on node status #292

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Jan 3, 2024

Acceptance Criteria

  • Addresses Implement support for sync-v2 when parsing node status #291
  • Make latest_timestamp and sync_timestamp optional
  • Add BlockInfo class and peer_best_block and synced_block fields with that class
  • Add protocol_version field and use that to choose which pair of fields to parse (the other pair will be None)
  • Update fixtures using examples from the latest deploy
  • Adjust tests accordingly

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@jansegre jansegre self-assigned this Jan 3, 2024
@jansegre jansegre requested a review from r4mmer as a code owner January 3, 2024 16:19
@jansegre jansegre force-pushed the feat/support-sync-v2-status branch from 7f5eb1b to e0ccf5e Compare January 3, 2024 16:30
@jansegre jansegre requested a review from luislhl January 3, 2024 16:31
@jansegre jansegre force-pushed the feat/support-sync-v2-status branch from e0ccf5e to 72b8977 Compare January 3, 2024 16:49
@jansegre jansegre merged commit 1f8f8f1 into dev Jan 4, 2024
4 checks passed
@jansegre jansegre deleted the feat/support-sync-v2-status branch January 4, 2024 14:42
This was referenced Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants