We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TxBuilder
TxBuilderRunner
to improve UX, we could unify the two classes.
The constructor would take either protocol params or IProvider
IProvider
if IProvider is passed the getProtocolParameters method can be used
getProtocolParameters
if protocol params are passed, all the async methods of TxBuilderRunner will throw an error.
Additonally the TxBuilder would benefit of the incremental methods exposed in the runner.
One approach for implementation would be to add a _buildArgs private property, that is updated with every TxBuilderRunner method
_buildArgs
when calling buildSync if other arguments are passed, the private property _buildArgs and the argument to the method should be merged
buildSync
buildSync should still be the only "final" way to build a tx.
The text was updated successfully, but these errors were encountered:
ScriptContextBuilder
No branches or pull requests
to improve UX, we could unify the two classes.
The constructor would take either protocol params or
IProvider
if
IProvider
is passed thegetProtocolParameters
method can be usedif protocol params are passed, all the async methods of
TxBuilderRunner
will throw an error.Additonally the
TxBuilder
would benefit of the incremental methods exposed in the runner.One approach for implementation would be to add a
_buildArgs
private property, that is updated with everyTxBuilderRunner
methodwhen calling
buildSync
if other arguments are passed, the private property_buildArgs
and the argument to the method should be mergedbuildSync
should still be the only "final" way to build a tx.The text was updated successfully, but these errors were encountered: