%num1% not replaced in buff description

[ideka]

All skills in palette 2934 (all enemy skills) reference a buff with this issue. The buff in question is 12862.

I'm guessing it should be changed around here but I'm not sure what the value is supposed to be.

[SaculRennorb]

Well, to be fair those skills don't properly work in game either:

I can however probably just fix them on the server side, shouldn't even be a huge deal.

I'll keep you updated.

[SaculRennorb]

Ok, in a moment the server will have pulled some new processing logic and i've already added some code to this lib to specifically account for this case (fix/108).

The code is very targeted which i usually try to avoid, which is also the reason why this is on a separate branch for now. You now have a fix for the issue, but im still debating if i should merge the solution int the main project.

Please add information about any similar issues, should you find any in the future.

[ideka]

Oh... dunno why I didn't think of creating a chat link to see how it looked ingame. Honestly if it's broken ingame too then I'd probably just leave it.

I will report back if I find other similar issues.

[SaculRennorb]

Well,,, part of the manifesto is to also fix things that are broken in the actual data, so i don't have any ironing out something like that. Its just I don't like hardcoding any ids, that's why I'm a bit hesitant about the current solution.

btw, this is how our version looks now:

interestingly there are some rounding errors on other parts - i need to look into those, but that should be unrelated.