Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrained auth methods #98

Open
ccnifo opened this issue Aug 14, 2018 · 2 comments
Open

Constrained auth methods #98

ccnifo opened this issue Aug 14, 2018 · 2 comments

Comments

@ccnifo
Copy link
Collaborator

ccnifo commented Aug 14, 2018

10_security.config.erb forces the same auth methods for the several params SEC_*_AUTHENTICATION_METHODS: is it a feature or can we make it more flexible?
Same question goes for the auth string: the very specific ordering of the auth methods (determined by a function), does it obey some constraint/best practice or can we make it more flexible?

@kreczko
Copy link
Member

kreczko commented Aug 14, 2018

That's just laziness ;).
In most places, you will find shortcuts that were treated as "good enough" - this is one of them.

For both the params and the auth string function I am open to suggestions.

@ccnifo
Copy link
Collaborator Author

ccnifo commented Aug 14, 2018

That makes sense :)
It looks like we might need a setup a bit more complex, if so I won't hesitate to submit PRs!
Changing the methods ordering sounds quite easy as it can be defined in 1 parameter, but taking into account the numerous SEC_*_AUTHENTICATION_METHODS would need some further thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants