From 5e1670cd0627b9205999c7f09bacf80d37183ccf Mon Sep 17 00:00:00 2001 From: AsgerGaardsvoll <104432907+AsgerGaardsvoll@users.noreply.github.com> Date: Wed, 7 Feb 2024 11:25:53 +0100 Subject: [PATCH 1/2] Update HepMCToEDMConverter.cpp Added line to get mass. Mass was not converted which would result in mass being 0 for all particles after conversion. --- k4Gen/src/components/HepMCToEDMConverter.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/k4Gen/src/components/HepMCToEDMConverter.cpp b/k4Gen/src/components/HepMCToEDMConverter.cpp index 9b8148c..747430f 100644 --- a/k4Gen/src/components/HepMCToEDMConverter.cpp +++ b/k4Gen/src/components/HepMCToEDMConverter.cpp @@ -17,6 +17,7 @@ edm4hep::MutableMCParticle HepMCToEDMConverter::convert(std::shared_ptr<const He // convert momentum auto p = hepmcParticle->momentum(); edm_particle.setMomentum( {float(p.px()), float(p.py()), float(p.pz())} ); + edm_particle.setMass( float ( hepmcParticle->generated_mass() ) ); // add spin (particle helicity) information if available std::shared_ptr<HepMC3::VectorFloatAttribute> spin = hepmcParticle->attribute<HepMC3::VectorFloatAttribute>("spin"); From 72307a9be06bbf117e1e8db1f50361df4f1cf0d4 Mon Sep 17 00:00:00 2001 From: AsgerGaardsvoll <104432907+AsgerGaardsvoll@users.noreply.github.com> Date: Thu, 8 Feb 2024 11:06:27 +0100 Subject: [PATCH 2/2] Update HepMCToEDMConverter.cpp Changed type from float to double for mass --- k4Gen/src/components/HepMCToEDMConverter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/k4Gen/src/components/HepMCToEDMConverter.cpp b/k4Gen/src/components/HepMCToEDMConverter.cpp index 747430f..06adc13 100644 --- a/k4Gen/src/components/HepMCToEDMConverter.cpp +++ b/k4Gen/src/components/HepMCToEDMConverter.cpp @@ -17,7 +17,7 @@ edm4hep::MutableMCParticle HepMCToEDMConverter::convert(std::shared_ptr<const He // convert momentum auto p = hepmcParticle->momentum(); edm_particle.setMomentum( {float(p.px()), float(p.py()), float(p.pz())} ); - edm_particle.setMass( float ( hepmcParticle->generated_mass() ) ); + edm_particle.setMass( double ( hepmcParticle->generated_mass() ) ); // add spin (particle helicity) information if available std::shared_ptr<HepMC3::VectorFloatAttribute> spin = hepmcParticle->attribute<HepMC3::VectorFloatAttribute>("spin");