-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] Get a button content more flexible #4
Comments
Hey @ruisebastiao thx for the issue, that's great feedback, but the I will investigate how I can add custom icon in |
In my scenario I needed access to my iconRegistry. I modified the HTML markup in the template of this library to the following and it gave the library the flexibility I needed. If you import fontawesome into the iconRegistry this may work for you. Here is link to thread on stack overflow that outlines using iconRegistry to import fontAwesome that may help. and here is the modification I made.
original |
@xxNoxiouSxx please were you able to get svgIcon to work with it? |
ngc-float-button.component.ts I modified the template this is a basic example of the concept. in my final implementation I needed to be able to dynamically change the icon by state and some other items... this required me to go further by creating additional inputs in the component for primary and secondary svgIcons and then modify the template logic further. |
ngc-float-button/components/ngc-float-button.component.ts
Lines 28 to 30 in e652337
I think the content of the button should be more flexible, in my case i want to use a Font Awesome icon so i propose to have something like this:
so i can use it like:
The text was updated successfully, but these errors were encountered: