Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slabs over honey block #1929

Open
spring-dependency-management opened this issue Jan 8, 2025 · 3 comments
Open

Slabs over honey block #1929

spring-dependency-management opened this issue Jan 8, 2025 · 3 comments
Labels
false positive False positive simulation Related to Simulation / Prediction engine

Comments

@spring-dependency-management
Copy link
Contributor

Describe the false positive and how to replicate it

Place slab atop honey blocks, grim simulation fails

2025-01-08.02-45-37.mp4

Grim Log

N/A

Server version

This server is running Paper version 1.21.4-DEV-main@49d15f6 (1970-01-01T00:00:00Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.4-DEV-3375570 (MC: 1.21.4)

Client version

1.21.4

Plugins

GrimAC version f852f16 (latest)

@spring-dependency-management spring-dependency-management added false positive False positive simulation Related to Simulation / Prediction engine labels Jan 8, 2025
@SamB440
Copy link
Contributor

SamB440 commented Jan 8, 2025

fyi, noone is or wants to fix the prediction engine. I only fixed stuff like camels and striders because it was an easy copy from pharus engine. For stuff like this I'd have no clue where the issue lies. I am working on a Grim implementation of pharus, but I don't know if I want to open source it because I'm tired of people stealing my work and I've spent literal years making it

@spring-dependency-management
Copy link
Contributor Author

spring-dependency-management commented Jan 8, 2025

fyi, noone is or wants to fix the prediction engine. I only fixed stuff like camels and striders because it was an easy copy from pharus engine. For stuff like this I'd have no clue where the issue lies. I am working on a Grim implementation of pharus, but I don't know if I want to open source it because I'm tired of people stealing my work and I've spent literal years making it

what is pharus engine?

also why not have a hackfixes class that just increases max allowed offset to the appropriate amount if they are on a slab with honey below, its what I have to do for several grim falses, I get that it would make the simulation no longer "perfect" but nothing is, seems redundant though for every server running grim to have to implement their own hack fixes (if they even do at all)

@SamB440
Copy link
Contributor

SamB440 commented Jan 8, 2025

Because that's not the proper fix and people would then complain about bypasses.

Pharus engine is my custom prediction engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive False positive simulation Related to Simulation / Prediction engine
Projects
None yet
Development

No branches or pull requests

2 participants