You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the JR model fitting, the naming convention for the long-range coupling parameters between ROIs needs to be changed. The current naming scheme is as follows:
Pyramidal to Inhibitory Cells: sc_m_b (from w_n_b>w_b>w_bb)
Pyramidal to Excitatory Cells: sc_m_f (from w_n_f>w_f>w_ff)
Pyramidal to Pyramidal Cells: sc_fitted (from w_n_l>w >w_ll)
This labeling is based on David (2005)’s hierarchical nomenclature for extrinsic coupling: backward (bottom-up), forward (top-down), and lateral connections.
However, this terminology seems inconsistent with how these couplings are fitted in WhoBPyt, as the fitting is done between all ROIs, not just in a hierarchical manner between sensory and higher-order regions as typically described in the Dynamic Causal Modeling (DCM) literature. Additionally, all three coupling types are fitted but only pyramidal to pyramidal is labelled as sc_fitted.
The suggestion is to rename these coupling variables to more accurately reflect their roles:
In whobpyt/models/JansenRit/jansen_rit.py
changed fitted sc vars: sc_m_b -> sc_p_i for Pyramidal to Inhibitory sc_m_f -> sc_p_e for Pyramidal to Excitatory sc_fitted -> sc_p_p for Pyramidal to Pyramidal
For the JR model fitting, the naming convention for the long-range coupling parameters between ROIs needs to be changed. The current naming scheme is as follows:
sc_m_b
(fromw_n_b
>w_b
>w_bb
)sc_m_f
(fromw_n_f
>w_f
>w_ff
)sc_fitted
(fromw_n_l
>w
>w_ll
)This labeling is based on David (2005)’s hierarchical nomenclature for extrinsic coupling: backward (bottom-up), forward (top-down), and lateral connections.
However, this terminology seems inconsistent with how these couplings are fitted in WhoBPyt, as the fitting is done between all ROIs, not just in a hierarchical manner between sensory and higher-order regions as typically described in the Dynamic Causal Modeling (DCM) literature. Additionally, all three coupling types are fitted but only pyramidal to pyramidal is labelled as
sc_fitted
.The suggestion is to rename these coupling variables to more accurately reflect their roles:
In whobpyt/models/JansenRit/jansen_rit.py
changed fitted sc vars:
sc_m_b
->sc_p_i
for Pyramidal to Inhibitorysc_m_f
->sc_p_e
for Pyramidal to Excitatorysc_fitted
->sc_p_p
for Pyramidal to Pyramidalchange connection gain variables:
w_bb
->w_pi
w_b
->w_i
w_n_b
->w_n_pi
w_ff
->w_pe
w_f
->w_e
w_n_f
->w_n_pe
w_ll
->w_pp
w_l
->w_p
w_n_l
->w_n_pp
In progress on Minarose/whobpyt:JR_sc
The text was updated successfully, but these errors were encountered: