Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate some automatic testing #120

Open
Andrew-Clappison opened this issue Aug 28, 2023 · 5 comments
Open

Generate some automatic testing #120

Andrew-Clappison opened this issue Aug 28, 2023 · 5 comments

Comments

@Andrew-Clappison
Copy link
Collaborator

Make unit tests based off of the current WhoBPyT examples that doesn't require visual inspection

@Andrew-Clappison
Copy link
Collaborator Author

@sbastiaens has examples to use as a reference

@P-Oveisi
Copy link
Collaborator

@Andrew-Clappison would the testing be more qualitative (i.e., does the code run properly?) or quantitative (i.e., how well it fits data, etc.)?

@P-Oveisi
Copy link
Collaborator

At this point, I'm implementing simple verification of parameter fitting in terms of making sure that the ones we indicated as free parameters are changing while the rest are not.

The fitting status for the parameters can be found in the Model_fitting object, where the intent to fit or not is within Model_fitting.model.params and the actual fitted params are found in Model_fitting.trainingStats.fit_params

code here
example notebook here
(there's an error due to pandas version that I haven't figured out yet)

Not sure if this is the direction we're looking at, don't want to commit to it too hard before getting some input from others.

@Davi1990
Copy link
Collaborator

@P-Oveisi please split the PR

@tmorshed tmorshed self-assigned this Dec 11, 2023
@Davi1990
Copy link
Collaborator

Davi1990 commented Dec 11, 2023

@tmorshed is working on automating it on PR #138.
Waiting for the tests to be generated by @kevinkadak and @P-Oveisi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants