Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency of Model Parameters #108

Open
Andrew-Clappison opened this issue Aug 11, 2023 · 3 comments
Open

Transparency of Model Parameters #108

Andrew-Clappison opened this issue Aug 11, 2023 · 3 comments

Comments

@Andrew-Clappison
Copy link
Collaborator

Convert RWW code to use log value so that the parameter returned by par() is actual value used (instead of min + ReLU(stored_value) being used).
Convert Jansen-Rit to use log value so that the parameter returned by par() is actual value used (instead of min + ReLU(stored_value) being used).

@Andrew-Clappison Andrew-Clappison self-assigned this Aug 11, 2023
@Andrew-Clappison
Copy link
Collaborator Author

To be done at a later time.

@Davi1990
Copy link
Collaborator

Davi1990 commented Dec 18, 2023

save it for the new year @Davi1990 happy to help in case is necessary

Considering using the exponential (instead of ReLu) for preventing to go negative

@Andrew-Clappison
Copy link
Collaborator Author

New approach (please assign someone else):

See if the minimum values above 0 can be removed or replaced using the asLog features, instead of adding a new ReLu feature to the par class.

Locations around:
https://github.com/GriffithsLab/whobpyt/blob/main/whobpyt/models/RWW/wong_wang.py#L361
https://github.com/GriffithsLab/whobpyt/blob/main/whobpyt/models/JansenRit/jansen_rit.py#L295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants