Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbortedMockServerTest.testRandomResults is flaky for dates in year 100 #2688

Open
olavloite opened this issue Dec 28, 2024 · 0 comments · May be fixed by #2781
Open

AbortedMockServerTest.testRandomResults is flaky for dates in year 100 #2688

olavloite opened this issue Dec 28, 2024 · 0 comments · May be fixed by #2781
Assignees
@olavloite
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@olavloite
Copy link
Collaborator 

Error:  Failures: 
Error:    AbortedMockServerTest.testRandomResults:929->assertEqual:1021 expected:<0100-02-19> but was:<0100-02-20>
@olavloite olavloite added the type: process A process-related concern. May include testing, release, or the like. label Dec 28, 2024
@olavloite olavloite self-assigned this Dec 28, 2024
olavloite added a commit that referenced this issue Jan 18, 2025
@olavloite
test: fix flaky random results test
54428cb 
The random results test would sometimes fail for dates in the year 100.
This was caused by the getDate(..) method using the local timezone to
calculate the date based on the number of days since the PG epoch.

Instead of using the getDate(..) method, the date should be retrieved
as a LocalDate, as that does not use any timezone information or rely
on any of the weird java.util.Date / java.sql.Date types.

Fixes #2688
@olavloite olavloite linked a pull request Jan 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky random results test GoogleCloudPlatform/pgadapter
1 participant
@olavloite