Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of default installation parameters for msiexec #654

Open
dryzhov opened this issue Aug 14, 2024 · 0 comments
Open

Wrong order of default installation parameters for msiexec #654

dryzhov opened this issue Aug 14, 2024 · 0 comments

Comments

@dryzhov
Copy link

dryzhov commented Aug 14, 2024

Steps to reproduce:

  1. create software installation recipe without definition of flags
  2. launch recipe

Result: msiexec dialog window with usage information

Expected result: installed msi package

Analyze:
Function policies/recipes/steps.go/stepInstallMsi contains code with default msiexec options

   args := step.Flags
   if len(args) == 0 {
   	args = []string{"/i", "/qn", "/norestart"}
   }
   args = append(args, path)

where path contain full path to *.msi file

By msiexec documentation parameter /i must contain value - package or product code. Then code may look like this:

	args := step.Flags
	if len(args) == 0 {
		args = []string{"/qn", "/norestart", "/i"}
	}
	args = append(args, path)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant