Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial monitor demo does not make a link clickable #66

Open
ldijkman opened this issue Feb 20, 2024 · 3 comments
Open

serial monitor demo does not make a link clickable #66

ldijkman opened this issue Feb 20, 2024 · 3 comments

Comments

@ldijkman
Copy link

ldijkman commented Feb 20, 2024

hello

playing with your demo
https://ldijkman.github.io/async-esp-fs-webserver/WebSerialMonitor.html

serial monitor demo does not make a link clickable

Tuesday, February 20 2024 17:06:33
mDNS at http://garage.local
Browsing for service _http._tcp.local. ... 1 service(s) found
  1: http://kitchen.local - http://10.10.100.100:80

http://garage.local and http://kitchen.local is a clickable link

http://10.10.100.100:80 is not a clickable link

Screenshot from 2024-02-20 18-02-53

@reillyeon
Copy link
Collaborator

We're just using the default configuration of the xterm-addon-web-links package. If this has been fixed upstream we can update our dependency.

@ldijkman
Copy link
Author

ldijkman commented Feb 22, 2024

problem is
links with
:port
are not linked

now it is ok
Screenshot from 2024-02-22 05-57-31

@ldijkman
Copy link
Author

i think it will be maybe fixed
xtermjs/xterm.js#4964 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants