Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carlo will not launch on win10 #148

Open
mu-yu opened this issue Mar 20, 2019 · 2 comments
Open

carlo will not launch on win10 #148

mu-yu opened this issue Mar 20, 2019 · 2 comments

Comments

@mu-yu
Copy link

mu-yu commented Mar 20, 2019

Accoding to some bug/feature in puppeteer, carlo/puppeteer will not launch on win10 sometimes. see: puppeteer/puppeteer#3186

here is how to fix I found:
when launch puppeteer, add an option ignoreDefaultArgs: ['--disable-extensions'], to puppeteer.launch in this line
https://github.com/GoogleChromeLabs/carlo/blob/master/lib/carlo.js#L619

@ThomasMcGarry101
Copy link

Adding the option "ignoreDefaultArgs: ['--disable-extensions']," does not appear to resolve the problem. Is this issue being addressed or are there any other short term work around?

@mu-yu
Copy link
Author

mu-yu commented May 30, 2019

Adding the option "ignoreDefaultArgs: ['--disable-extensions']," does not appear to resolve the problem. Is this issue being addressed or are there any other short term work around?

The option shoud put into the source of carlo where carlo init the pptr, not the code of yours where init carlo.Carlo doesn't have this option at the moment.

see: puppeteer/puppeteer#3186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants