Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face Verification Flow - Event improvements #4153

Open
drptiago opened this issue Dec 6, 2023 · 5 comments
Open

Face Verification Flow - Event improvements #4153

drptiago opened this issue Dec 6, 2023 · 5 comments
Assignees

Comments

@drptiago
Copy link
Collaborator

drptiago commented Dec 6, 2023

Motivation

Right now I am saving the Face Verification events from https://goodid.gooddollar.org/  in a separate Google Analytics.
https://analytics.google.com/analytics/web/#/p415617260/reports/intelligenthome

The goal of this is to put all FV events ( from the wallet, gooddaap, opera and other partners) in the same place.

But, inside this GA I can't say what is the source to analyze the FV of each product, example:

  • The opera FV converts more than the GoodDaap FV or valora FV?

To achieve this I want to add an extra parameter in the FV events OR push forward the querystring parameter.

Details

From the partners using gooddapp, all of them are using the parameter partner in the URL:

https://gooddapp.org/?partner=valora

If we can push this parameter forward to https://goodid.gooddollar.org/ example  https://goodid.gooddollar.org/?partner=valora the problem will be addressed.

Other option is add the parameter product to all FV events, who will show the source of that user ( wallet, gooddapp, opera, valora, etc) and I can use to filter.

The first option seems the better.

@drptiago drptiago self-assigned this Dec 6, 2023
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Dec 6, 2023

@johnsmith-gooddollar @sirpy
for specifically partners that come from gooddapp, the best way would to do the paramater passing down as @drptiago suggests right?

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 29, 2024

@decentralauren @patpedrosa
maybe this should be added to the good-id epic

@patpedrosa
Copy link
Collaborator

@L03TJ3 Theoretically, this isn't part of the GoodID Epic but it's work that we can do this sprint, so I'm tagging it with Sprint 9.

@decentralauren
Copy link

@L03TJ3 investigate if this is possible now with Reown / updates in new picker modal.

@sirpy
Copy link
Contributor

sirpy commented Jan 1, 2025

@L03TJ3
@drptiago
The FV flow is either triggered by a redirect from another website ie goodwallet.xyz redirect go goodid.gooddollar.org
Or it is embedded ie in gooddapp
So you have 3 cases

  1. collect document.referer
  2. use fixed product value such as gooddapp
  3. mobile wallets like minipay/valora - minipay has the ethereum.isMinipay, probably also other wallets. so we could look for ethereum.is* field and use that as the product value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants