Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to switch networks #214

Open
sirpy opened this issue Jul 10, 2024 · 5 comments · Fixed by #282
Open

feat: add ability to switch networks #214

sirpy opened this issue Jul 10, 2024 · 5 comments · Fixed by #282
Assignees

Comments

@sirpy
Copy link
Contributor

sirpy commented Jul 10, 2024

see also #181

If user is not connected to Celo currently UI just shows unsupported network.
Usually it should be a button or modal triggering switch network request to metamask.
Also since we are just on celo perhaps it should already say switch to celo

image.png

Implementation Description:
When user is connected to a non supported network the UI should automatically ask user to switch network

  • only trigger switch if user has connected a wallet
  • show a modal to user asking to switch network
  • trigger switch network on metamask like wallets

Technical description

  • handle edge case when connecting to a wallet via walletconnect, and the wallet doesnt support Celo
@decentralauren
Copy link

@sirpy good catch. Let's please follow the pattern we have on GoodDapp / implementation we have there. cc @L03TJ3

@sirpy sirpy changed the title no option to switch network feat: add ability to switch networks Oct 8, 2024
@eben619
Copy link

eben619 commented Oct 26, 2024

Hello, @sirpy @decentralauren can i get assigned to this?

@sirpy
Copy link
Contributor Author

sirpy commented Oct 27, 2024

@eben619 are you refering to the scouts game? I don't believe you need to be assigned to it, just submit a PR

@Immadominion
Copy link

Can I be assigned to this task?

I can follow the implementatio @ https://github.com/L03TJ3 to add ability to switch networks

@sirpy
Copy link
Contributor Author

sirpy commented Dec 8, 2024

@Immadominion @eben619 you don't need to be assigned, just propose a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants