Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Netcode 1.01 #7

Closed
toqueteos opened this issue Sep 2, 2017 · 6 comments
Closed

Update to Netcode 1.01 #7

toqueteos opened this issue Sep 2, 2017 · 6 comments

Comments

@toqueteos
Copy link

A small change was introduced some days ago and Netcode 1.01 was born. The library needs updating.

I might send a PR for this in a few days, I've have only worked on the Go flavor of netcode.

@GlaireDaggers
Copy link
Owner

GlaireDaggers commented Sep 2, 2017

I can go ahead and make a quick update. Though, is the new version info string and the rearranged placement of the timeout seconds the only change that needs to be made for 1.01 (as indicated in that diff linked) or are there more changes that need to be made beyond that?
EDIT: Well, re-reading the spec I guess there's other changes too. Also adding timeout seconds to private key too, as well as server's client timeout logic. As far as I can tell those are all of the changes for 1.01?

@toqueteos
Copy link
Author

I think those are all the changes yes. @gafferongames can confirm though.

Overall it's a small change but it breaks compatibility with v1.00.

@gafferongames
Copy link

Yeah, it just adds the timeout data to the token private, plus there needs to be a pretty significant adustment to how clients timeout, and how the encryption mapping times out (different value per-client, coming from the token...). Also, the client sets its timeout value from the connect token.

cheers

  • Glenn

@gafferongames
Copy link

Look at the diffs on the spec, and on the netcode.c, should be clear what changes are there. Happy to answer any questions you have.

@gafferongames
Copy link

Oh yeah, and negative timeout values indicate "timeout disabled". This is the hardest part.

More info on changes from 1.00 to 1.01 here:

https://github.com/networkprotocol/netcode.io/releases

@GlaireDaggers
Copy link
Owner

Just committed an update which brings it up to the v1.01 spec (plus a few unrelated changes and a fix to allow negative expire time to be passed to token factory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants