Skip to content
This repository has been archived by the owner on Dec 30, 2024. It is now read-only.

Payments are restricted to only one token, and if a token is defined #35

Open
3esmit opened this issue Jun 21, 2017 · 2 comments
Open

Comments

@3esmit
Copy link

3esmit commented Jun 21, 2017

Any reason for not being multitoken?
If I have a bounty contract and I want to send some valuable, rare and fun tokens to be rewarded, such as SNT, ETH, GNT, BEER, Unicorns and DAO.

This was referenced Jun 21, 2017
@3esmit
Copy link
Author

3esmit commented Jun 22, 2017

This can lead to unknown behavior of external token calls. If unknown tokens are called, they might throw or return unexpected values. An idea would be to create an array of accepted tokens, or turn design into that this would never be an issue (no one would care about an unknown buggy "token", so it will be ignored into the blockchain.

@GriffGreen
Copy link
Member

A whitelist of tokens is probably the right answer... The more i think about this, the more I like the idea of ripping the payment struct and the whitelist out of this contract and into an external contract

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants