Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more QgisInterface functionality to the stub class #24

Open
Joonalai opened this issue Jun 17, 2022 · 0 comments · May be fixed by #54
Open

Implement more QgisInterface functionality to the stub class #24

Joonalai opened this issue Jun 17, 2022 · 0 comments · May be fixed by #54
Labels
enhancement New feature or request

Comments

@Joonalai
Copy link
Contributor

Expected behaviour
Most of QgisInterface methods should be implemented. Also some signals should be emitted when calling appropriate methods. For example currentLayerChanged should be emitted when calling setActiveLayer.

Current behaviour
Only some of the functionality is implemented and calling unimplemented methods raises errors.

Describe alternatives you've considered
Wrap the whole class inside MagicMock.
@Joonalai Joonalai added the enhancement New feature or request label Jun 17, 2022
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Nov 14, 2023
@Joonalai
refactor: use original QgisInterface as base class [GispoCoding#24]
44782df
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 15, 2023
@Joonalai
refactor: use original QgisInterface as base class [GispoCoding#24]
aa9c3b5
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 15, 2023
@Joonalai
WIP use original QgsMessageBar as base class [GispoCoding#24]
7c9f179
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 15, 2023
@Joonalai
Use original QgisInterface as base class [GispoCoding#24]
7a62f1e
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 15, 2023
@Joonalai
Update QgisInterface class and refactor and improve tests [GispoCodin…
d9701e5 
…g#24]
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 15, 2023
@Joonalai
Update QgisInterface class and refactor and improve tests [GispoCodin…
800d9c5 
…g#24]
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 15, 2023
@Joonalai
Update QgisInterface class and refactor and improve tests [GispoCodin…
82b4875 
…g#24]
@Joonalai Joonalai linked a pull request Dec 15, 2023 that will close this issue
Open
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 18, 2023
@Joonalai
Update QgisInterface class, refactor and improve tests [GispoCoding#24]
f0a76ac
Joonalai added a commit to Joonalai/pytest-qgis that referenced this issue Dec 18, 2023
@Joonalai
Update QgisInterface class, refactor and improve tests [GispoCoding#24]
64ad100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make stub QgisInterface and MockMessageBar inherit real interfaces Joonalai/pytest-qgis
1 participant
@Joonalai