AskTPL class only handles rank species

[mfrasca]

reported by @fruit-github: (#147)

I have had an issue adding a species more recently that I think should have given a result from the green button. Adding Gymnocalycium damsii, reponse is..
No match found on ThePlantList.org
yet searching ThePlantList.org gives http://www.theplantlist.org/tpl1.1/search?q=Gymnocalycium+damsii

this seems caused by the fact that tpl does not contain a taxon that is used as accepted name for the given query.

quick solution to this case:

@@ -105,7 +105,15 @@ class AskTPL(threading.Thread):
             else:
                 raise NoResult
             if found['Accepted ID']:
-                accepted = ask_tpl(found['Accepted ID'])[0]
+                logger.debug("found this: %s", str(found))
+                accepted = ask_tpl(found['Accepted ID'])
+                logger.debug("ask_tpl on the Accepted ID returns %s", accepted)
+                if accepted:
+                    accepted = accepted[0]
+                else:
+                    logger.warning("taxon is marked as synonym, but can't "
+                                   "access accepted form %s", found['Accepted ID'])
+                    accepted = None
                 logger.debug("%s after second query", self.name)
             if self.stopped():
                 raise ShouldStopNow('after second query')

[mfrasca]

looks like I made an incorrect statement.
the referred to taxon is in TPL but it is at rank subspecies, and my ask_tpl method filters away anything that is at rank lower than species, so it does not find it.
Gymnocalycium damsii (K.Schum.) Britton & Rose is a synonym of Gymnocalycium anisitsii subsp. damsii (K.Schum.) G.J.Charles

to correct the behaviour of ghini, we need adding the handling of infraspecific taxonomic information.

[mfrasca]

a quick and incomplete correction:

when you click on the sp_species_button button, ghini start the lookup (check #151).

as soon as the lookup ends (or times out), ghini removes all previous message boxes and shows the results.
result can be:

• no result
• this is the closest match

and can be followed by:

• closest match is a synonym of this other species
• closest match is a synonym of something at infraspecific rank, which I cannot handle.

[mfrasca]

[fruit-github]

That looks a great improvement to me, thanks

I guess from your 'but I'm afraid this should go to 1.0-dev' that this is not available from a '-u' update - and that itself is not a problem as I see it

[mfrasca]

indeed, not yet published on the ghini-1.0 branch, you either wait until I do so, it will be 1.0.60, or you explicitly move to the ghini-1.0-dev branch.

[fruit-github]

Happy to wait thanks