Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry SDKs use in other SDKs is not officially supported #41

Closed
krystofwoldrich opened this issue May 19, 2023 · 8 comments
Closed

Sentry SDKs use in other SDKs is not officially supported #41

krystofwoldrich opened this issue May 19, 2023 · 8 comments

Comments

@krystofwoldrich
Copy link

krystofwoldrich commented May 19, 2023

Sentry and MetaMap customer reported an issue related to sentry-react-native and react-native-metamap-sdk upon closer inspection it looks like Meta Maps iOS SDK uses Sentry and that's different from the Sentry version the customer installed. This causes the app to crash.

One possible solution would be not to remove Sentry from the SDK or guide users to use the same version of the SDK.

Note that Sentry officially doesn't support the use of the SDK in other SDKs. More on the topic here. Having Sentry SDK in an app twice can cause issues and errors and also endanger end-user privacy by reporting issues to app developer but also to the SDK dev.

@AvoSukiasyan
Copy link
Collaborator

AvoSukiasyan commented May 19, 2023

hi @krystofwoldrich . I know about this problem which you mentioned but it's only happening in one client. We integrated Sentry SDK as a private package and it makes it to skip conflict, but in some cases like this, the conflict appears :(

@3KINGZ
Copy link

3KINGZ commented May 22, 2023

hi @krystofwoldrich . I know about this problem which you mentioned but it's only happening in one client. We integrated Sentry SDK as a private package and it makes it to skip conflict, but in some cases like this, the conflict appears :(

@AvoSukiasyan what do you suggest we do?, this issue is currently preventing us from integrating meta-map on our app

@AvoSukiasyan
Copy link
Collaborator

@3KINGZ can you tell me which Sentry version you use? I'll add it to my example project, check it, and get back to you.

@3KINGZ
Copy link

3KINGZ commented May 22, 2023

@AvoSukiasyan
sentry-expo: 4.0.0
@sentry/react-native: 4.3.0

@AvoSukiasyan
Copy link
Collaborator

will check and get back to you , thanks @3KINGZ

@jesuscast
Copy link

@AvoSukiasyan we also have this issue. It would be better if Metamap didn't include Sentry.

This forced us to fork the Metamap SDK and remove Sentry manually.

@3KINGZ you can try to use our fork: https://github.com/jesuscast/metamap-ios-sdk

It's stuck in the SDK version 3.12 however.

@AvoSukiasyan
Copy link
Collaborator

Hi @jesuscast. from your commits, I get that you removed sentry files but The Sentry methods from the MetaMap exist and I think the methods are calling your Sentry files. by the way, I fixed the issue and this fix will be included in the next release. I"ll release SDK and get back to you.
cc: @3KINGZ

@AvoSukiasyan
Copy link
Collaborator

the problem is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants