fix(components): Keep only one DatePicker open at a time #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying atlantis with
|
| Latest commit: |
8da1e03
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29366166.atlantis.pages.dev |
| Branch Preview URL: | https://job-116104-job-116904-one-da.atlantis.pages.dev |
taylorvnoj
changed the title
taylorvnoj
commented
Feb 25, 2025
| @@ -115,7 +117,7 @@ export function DatePicker({ | |||
| const datePickerClassNames = classnames(styles.datePicker, { | |||
| [styles.inline]: inline, | |||
| }); | |||
| const { pickerRef } = useEscapeKeyToCloseDatePicker(open, ref); | |||
| const { pickerRef } = useEscapeKeyToCloseDatePicker(open); | |||
There was a problem hiding this comment.
the ref removed from here wasn't needed for ESC key functionality; ESC key handler only needs pickerRef to call setOpen(false) and doesn't need the wrapper's ref.
taylorvnoj
commented
Feb 25, 2025
Comment on lines
+175
to
+182
| if ( | ||
| openDatePickerRef.current && | ||
| openDatePickerRef.current !== pickerRef.current | ||
| ) { | ||
| openDatePickerRef.current.setOpen(false); | ||
| } | ||
|
|
||
| openDatePickerRef.current = pickerRef.current; |
There was a problem hiding this comment.
Checks if there's already an open picker that's different from the current one and if found, closes the other picker.
|
Published Pre-release for 8da1e03 with versions: To install the new version(s) for Web run: |
Aiden-Brine
previously approved these changes
Feb 26, 2025
taylorvnoj
dismissed
MichaelParadis’s stale review
As discussed with the team we are going to try a different approach; I'm currently using a global variable which is a React anti-pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
If an
InputDateis open and focus is shifted to anotherInputDate, they will both stay open. This can cause UX confusion & unintended side effects, especially when inputs are very close together. This PR addresses that and makes sure only 1DatePickercan be open at a time.Changes
Added
Changed
Testing
<InputDate />for an<InputText />and when focus goes to theInputText, the picker closesChanges can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.