fix(components): There was a typo in the DataList.ItemAction logic #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying atlantis with
|
| Latest commit: |
0911d11
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d66a6818.atlantis.pages.dev |
| Branch Preview URL: | https://job-114615-job-116871-shame.atlantis.pages.dev |
itsleaheye
commented
Feb 24, 2025
| @@ -46,7 +46,7 @@ export function DataListActions<T extends DataListObject>({ | |||
| const actionLabel = getActionLabel(); | |||
|
|
|||
| // If the action is always visible, we don't want a tooltip. | |||
| if (props.alwaysVisibled) { | |||
| if (props.alwaysVisible) { | |||
There was a problem hiding this comment.
I am curious about how CI didn't catch this when compiling the typescript 🤔
There was a problem hiding this comment.
That was my thought. It should have flagged it as an undefined var. I'll look at adding an additional unit test
There was a problem hiding this comment.
I was able to figure out why. Because the of the way children for the actions are retrieved the type is any so it can't actually know.
Thanks for adding the test, let me know when that is done and I can merge this and get it into the version bump
There was a problem hiding this comment.
Tests are added. Just waiting on CI 😎
MichaelParadis
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
I merged a typo with my branch last week that prevents the persistent ItemActions from rendering correctly. For shame.
Fixed
Testing
docs/components/DataList/Web.stories.tsxand set one of the item actions to alwaysVisible={true}, delete the other item actionsIn Atlantis we use Github's built in pull request reviews.