feat(components-native): add InlineLabel #2216
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying atlantis with
|
| Latest commit: |
8616c06
|
| Status: | 🚫 Build failed. |
chris-at-jobber
changed the title
scotttjob
reviewed
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
We have an InlineLabel in the RN codebase that is functionally and visually identical to our web version, so it should be promoted and they can live together in parity
Changes
Added
InlineLabelcomponent tocomponents-nativeTesting
To be truly rigorous, you could import this into the mobile repo and replace the "local" version. Otherwise, this is functionally net-new so testing the component's props behave as expected should suffice.
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.