Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-strict allowance of phone numbers #5

Open
GenFusion122 opened this issue Nov 11, 2022 · 1 comment
Open

Non-strict allowance of phone numbers #5

GenFusion122 opened this issue Nov 11, 2022 · 1 comment

Comments

@GenFusion122
Copy link
Owner

GenFusion122 commented Nov 11, 2022

image.png

Entering alphabets into a phone number is allowed with the message "This student's phone number appears to be invalid... ", however considering the other strict parameters such as email, telegram handle, github username, etc... it feels out of place and doesn't fit in well with the other more strictly parsed fields.

@soc-pe-bot
Copy link

soc-pe-bot commented Nov 14, 2022

Team's Response

According to the module website, it is better to warn rather than block incorrect inputs. As such, phone numbers such as 1234 5678 (HP) 1111-3333 (Office) can be accepted as recommended by the module website as well. By not forcing phone numbers to conform to a certain format, we are giving students more flexibility. Blocking such inputs might not add any value but allowing it does.

Screenshot 2022-11-12 at 13.25.08.png
(From https://nus-cs2103-ay2223s1.github.io/website/admin/tp-pe.html#pe-phase-2-developer-response-2)

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants