Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in email verification #3

Open
GenFusion122 opened this issue Nov 11, 2022 · 1 comment
Open

Inconsistency in email verification #3

GenFusion122 opened this issue Nov 11, 2022 · 1 comment

Comments

@GenFusion122
Copy link
Owner

GenFusion122 commented Nov 11, 2022

image.png

Emails are allowed without a .com or .something value in them, it should at least check for a ".something" value as no domain I know can be accessed without one.

@nus-se-script
Copy link

nus-se-script commented Nov 14, 2022

Team's Response

Emails are valid without a TLD ie. without a .com or .something.

Here are some links as to what constitutes a valid email:
https://en.wikipedia.org/wiki/Email_address#Examples

HTML5 also accepts emails without a TLD as seen here

image.png

There are also several such bugs reported in the previous year's PE that was rejected.

nus-cs2103-AY2122S1/pe-dev-response#5864

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants