Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguity in Model Class Diagram #10

Open
GenFusion122 opened this issue Nov 11, 2022 · 1 comment
Open

Ambiguity in Model Class Diagram #10

GenFusion122 opened this issue Nov 11, 2022 · 1 comment

Comments

@GenFusion122
Copy link
Owner

GenFusion122 commented Nov 11, 2022

image.png

There are multiplicities given for Interest and Module, however, the lack of a multiplicity value for Github, Phone and Email objects gives the impression that those fields are not optional, as they have the same (none) multiplicity as the required Name and Telegram objects. But that's not the case in the actual program where a person's Github, Phone and Email could be null values.

@nus-pe-script
Copy link

nus-pe-script commented Nov 14, 2022

Team's Response

The tester categorised this issue as Medium but we feel that it should be Low, as whatever is shown is correct, but according to the tester is missing some information.

Furthermore, we feel that this issue is not a bug.

Multiplicities are optional, as seen from the module website which says "Association multiplicities and the default value can be shown as part of the attribute using the following notation. Both are optional". Hence, omitting them is fine.
Screenshot 2022-11-14 at 21.49.12.png

Furthermore, although adding multiplicities for all the fields may provide the reader with more information, we feel that it will instead confuse them due to the excess information in one diagram. According to the DG Tips on module website, we were advised not to add too many details to the diagram. Therefore, we deliberately chose to add multiplicities to Interest and Module only to show that there exists a one-to-many relationship. As for the mandatory fields Name and Telegram as well as optional fields GitHub, Phone and Email, they are already stated very clearly in the UG. The command format that we have used are explained clearly under Take note of the Command Format.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: I do not agree, I understand the omission for multiplicity in a class diagram if none of the relationships shows any multiplicity.
However, I think in this case, where there are some multiplicities for some relationships brings with it the implication that the ones that do not have a multiplicity have the same values.


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants