Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptol Docker image doesn't display git commit version properly #1814

Open
RyanGlScott opened this issue Feb 26, 2025 · 0 comments
Open

cryptol Docker image doesn't display git commit version properly #1814

RyanGlScott opened this issue Feb 26, 2025 · 0 comments
Labels
bug Something not working correctly CI Continuous integration

Comments

@RyanGlScott
Copy link
Contributor

If you build cryptol from source and run --version on the resulting binary, it will tell you the git commit and branch information:

$ cabal -v0 run exe:cryptol -- --version
Cryptol 3.2.0.99
Git commit a172900c8fad75256f1fb3b8dfc6b7c62f1fd065
    branch master
FFI enabled

Unfortunately, doing the same thing in the Docker image does not produce any git-related information:

$ docker run --rm ghcr.io/galoisinc/cryptol:nightly --version
Cryptol 3.2.0.99
Git commit UNKNOWN
    branch UNKNOWN
FFI enabled

This is due to a silly oversight. The Docker image does not install git before compiling cryptol, and as a result, the build process is unable to embed the git commit/branch information into the cryptol binary.

@RyanGlScott RyanGlScott added the CI Continuous integration label Feb 26, 2025
@RyanGlScott RyanGlScott self-assigned this Feb 26, 2025
@RyanGlScott RyanGlScott added the bug Something not working correctly label Feb 26, 2025
@RyanGlScott RyanGlScott removed their assignment Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something not working correctly CI Continuous integration
Projects
None yet
Development

No branches or pull requests

1 participant