Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Pre-commit hooks #2

Open
Matthew-Whitlock opened this issue Oct 17, 2023 · 1 comment
Open

Feature Request: Pre-commit hooks #2

Matthew-Whitlock opened this issue Oct 17, 2023 · 1 comment

Comments

@Matthew-Whitlock
Copy link

https://pre-commit.com/index.html could let you set up linting etc. to run before local commits so you could maybe run faster and skip the Github Actions wait. And you could reuse the pre-commit hooks as github actions to keep that functionality.

Disclaimer: I've never used this and I want you to use it so I can bother you when I'm trying to learn it later. But it does seem cool for this project. But I will be bothering you later if you do use it.

@james-choncholas
Copy link
Collaborator

The linter runs as a vscode extension as you type and so the github action is more of a final check before submission thing. The pre-commit hook would be useful for those who don't use vscode though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants