Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE2 Fluid Crafting Encoded Pattern loses canBeSubstitute and combine status #19147

Closed
3 tasks done
TwoDCube opened this issue Feb 23, 2025 · 0 comments · Fixed by GTNewHorizons/AE2FluidCraft-Rework#268
Closed
3 tasks done
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed

Comments

@TwoDCube
Copy link

Your GTNH Discord Username

TwoDCube

Your Pack Version

2.7.2 and 2025-02-22+878 nightly

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

AE2 Fluid Crafting Encoded Pattern works with the AE2 terminal "Use as substitution" and "Merge the same items" buttons. Same as normal AE2 patterns.

Let's assume the following crafts

Image
Image
The 1k ME Storage Component should be using the circuitPrimitive oredict to automatically craft Vacuum Tube.

Like this:
Image

The Reality

When the Fluid Crafting Encoded Pattern gets converted to an ItemStack, the code writes NBT tags combine and beSubstitute into the ItemStack.
https://github.com/GTNewHorizons/AE2FluidCraft-Rework/blob/e88af75f400479c132e0dc550004a9f7c8195b15/src/main/java/com/glodblock/github/util/FluidPatternDetails.java#L167-L168
However when it read from the ItemStack, these NBT tags get ignored, so by default, none of these options are set.
https://github.com/GTNewHorizons/AE2FluidCraft-Rework/blob/e88af75f400479c132e0dc550004a9f7c8195b15/src/main/java/com/glodblock/github/util/FluidPatternDetails.java#L185-L194

So in the example above, the current versions complain about not having 4 "Any ULV Circuits".
Image

Your Proposal

Read these NBT tags when creating a FluidPatternDetails.
Like: GTNewHorizons/AE2FluidCraft-Rework#268

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed
Projects
None yet
1 participant