Add register user mutation #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hope-for-haiti ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kavinphan
requested changes
Feb 1, 2025
| * @returns 200 | ||
| */ | ||
| export async function POST(req: NextRequest) { | ||
| const parsed = schema.safeParse(await req.formData()); |
There was a problem hiding this comment.
TIL about safeParse, nice
Comment on lines
+39
to
+53
| const existingUser = await db.user.findUnique({ | ||
| where: { | ||
| email: userInvite.email | ||
| } | ||
| }); | ||
| if (existingUser) { | ||
| return conflictError("User already exists"); | ||
| } | ||
| const newUsers = await db.user.create({ | ||
| data: { | ||
| email: userInvite.email, | ||
| passwordHash: await argon2.hash(password), | ||
| type: userInvite.userType | ||
| } | ||
| }); |
There was a problem hiding this comment.
dont use a query to look up existing account-- the db will throw an error because we have a unique index on email
Comment on lines
+22
to
+31
| const goodFormData = new FormData(); | ||
| goodFormData.append('inviteToken', 'test_token'); | ||
| goodFormData.append('password', 'test_password'); | ||
|
|
||
| const mockUser: User = { | ||
| type: UserType.SUPER_ADMIN, | ||
| id: 0, | ||
| email: "[email protected]", | ||
| passwordHash: "hashed_test_password" | ||
| }; |
There was a problem hiding this comment.
super duper tiny nit: not ideal to have mutable data live outside of the scope of tests. theres a chance they could be changed between tests and affect runs
There was a problem hiding this comment.
one solution is to have these be generator functions that get called in each individual test
| type: userInvite.userType | ||
| } | ||
| }); | ||
| return NextResponse.json(newUsers, {status: 200}); |
There was a problem hiding this comment.
dont return the created user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8
Checklist