Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a larger number of sites with old scan dates #1062

Closed
gbinal opened this issue Jul 1, 2024 · 3 comments
Closed

There's a larger number of sites with old scan dates #1062

gbinal opened this issue Jul 1, 2024 · 3 comments
Assignees

Comments

@gbinal
Copy link
Member

gbinal commented Jul 1, 2024

About 1300 or so, by my count.

Folder of exports, for convenience

@akuny
Copy link

akuny commented Jul 17, 2024

In an effort to better understand why certain websites have stale scan results (that is, scan results that were last updated prior to the vast majority of other scan results), we created a GitHub Action called "Requeue stale scans" that selects all scan results that were last updated prior to three days before the current date and rescan them. Note that the three-day gap is arbitrary and can be adjusted as needed moving forward: https://github.com/GSA/site-scanning-engine/blob/8a1fa39b36ee3a4ec6692d0f0c32e7bc0795c108/libs/database/src/websites/websites.service.ts#L65

Using this action to scan these particular websites in isolation and then reviewing logs to better understand the problem led to a fix to the way the engine parses scan errors. After implementing this fix, all but one of the websites that were rescanned successfully wrote core results to the database.

@gbinal
Copy link
Member Author

gbinal commented Jul 17, 2024

great work!!

@gbinal gbinal closed this as completed Jul 17, 2024
@gbinal
Copy link
Member Author

gbinal commented Jul 26, 2024

This was overwhelmingly successful. There's 3-4 sites left that may be weirdos, so let's look one last time at those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants