Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Standards]: Modularity and decoupling of code #143

Open
joshbruce opened this issue Oct 5, 2016 · 2 comments
Open

[Standards]: Modularity and decoupling of code #143

joshbruce opened this issue Oct 5, 2016 · 2 comments
Labels

Comments

@joshbruce
Copy link
Contributor

Issue type

  • Standards & approach

Description

During R7S5 retrospective the notion of making sure our code is being developed in a modular and decoupled fashion came up. While not a specific action item for R7S6, believe this conversation is worthwhile.

During reviews I've seen a few areas where we can decouple concepts:

  1. User interface components as Angular 2.0 components.
  2. Interfacing with the APIs - an "API Kit".
  3. SAM Web Design Standards CSS, JS, and the US Web Design Standards.

@carlosvalle @JihadMotii-REISys @diego-ruiz-rei @tarandhupar @jagannathch

@joshbruce
Copy link
Contributor Author

We had a follow-up workshop related to the future of the SAM Web Design Standards. Believe it would be prudent to begin considering folder structure for the Angular 2.0 components. Maybe follow the deprecated UI Kit, which follows the SAMWDS stylesheets...??

Creates a single mapping across the repositories.

@jbabbs
Copy link

jbabbs commented Oct 8, 2016

This is only in regards to the App module for the sam-front-end project.

I really like the REI approach of separating the top-level routes into their own module. I also like @JihadMotii-REISys 's approach of defining the program route, within the search module (see program.routing.ts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants