Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes deprecated apis #1198

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Removes deprecated apis #1198

merged 3 commits into from
Apr 17, 2024

Conversation

brentryanjohnson
Copy link
Contributor

  • Fixes #874 and #875
  • Removes documentation references for emuseum and go.usa

@brentryanjohnson brentryanjohnson marked this pull request as ready for review April 17, 2024 17:57
vickimcfadden
vickimcfadden approved these changes Apr 17, 2024
View reviewed changes
Copy link

@vickimcfadden vickimcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

vickimcfadden
vickimcfadden previously approved these changes Apr 17, 2024
View reviewed changes
@brentryanjohnson
Copy link
Contributor Author

@jfredrickson suggested leaving code.json as-is for now, so reverting last commit.

vickimcfadden
vickimcfadden approved these changes Apr 17, 2024
View reviewed changes
Copy link

@vickimcfadden vickimcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfredrickson jfredrickson merged commit d923eb3 into master Apr 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vickimcfadden vickimcfadden vickimcfadden approved these changes

@jfredrickson jfredrickson Awaiting requested review from jfredrickson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove eMusuem API
3 participants
@brentryanjohnson @vickimcfadden @jfredrickson