Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POA&M - remediations/lifecycle ="planned" error #461

Closed
12 tasks
Telos-sa opened this issue Aug 3, 2023 · 7 comments
Closed
12 tasks

POA&M - remediations/lifecycle ="planned" error #461

Telos-sa opened this issue Aug 3, 2023 · 7 comments
Assignees

Comments

@Telos-sa
Copy link

Telos-sa commented Aug 3, 2023

Extended Description

  • Validation error seems to be referencing the wrong structure, or json is not being translated back into xml appropriately.
    Json structure the response objects are collected within "remediations". The schematron is looking for "response".

Preconditions

  • Preconditions…

Acceptance Criteria

  • More acceptance criteria…
    Review and determine if the schematron rule needs to be repointed, or if the issue is in the method of converting from json to xml. Once determined, fix as appropriate so the error no longer presents when the lifecycle="planned" is present but located within remediations.

Story Tasks

  • Tasks…

Definition of Done

  • [X ] Acceptance criteria met
  • Unit test coverage of our code > 95%
  • Automated code quality checks passed
  • Security reviewed and reported
  • Reviewed against plain language guidelines
  • Code must be self-documenting
  • No local tech debt
  • Load/performance tests passed – needs to be created/automated
  • Documentation updated
  • Architectural Decision Record completed as necessary for significant design choices
  • PR reviewed & approved
  • Source code merged
    FakeSubmissionPackage.zip
@Telos-sa
Copy link
Author

Telos-sa commented Aug 3, 2023

Evidence provided that showing planned is included. And provided submission package for review as well (fake data)
image

@volpet2014 volpet2014 self-assigned this Aug 24, 2023
@volpet2014
Copy link
Contributor

Is this for Rev 4 or Rev 5 or both?

@Telos-sa
Copy link
Author

REV 4 is the location.

@dimitri-zhurkin-vitg
Copy link
Contributor

There is a discrepancy between NIST OSCAL JSON structure (https://pages.nist.gov/OSCAL-Reference/models/v1.1.1/plan-of-action-and-milestones/json-outline/) and NIST OSCAL XML structure (https://pages.nist.gov/OSCAL-Reference/models/v1.1.1/plan-of-action-and-milestones/xml-outline/).

We'll discuss this issue with NIST.

@dimitri-zhurkin-vitg dimitri-zhurkin-vitg self-assigned this Oct 17, 2023
@vitggsa
Copy link

vitggsa commented Nov 1, 2023

FYI - NIST has identified that the SAR has the same discrepancy. Just following up.

@david-waltermire
Copy link
Member

This relates to usnistgov/OSCAL#1956.

@david-waltermire david-waltermire moved this from 🆕 New to 📋 Backlog in FedRAMP Automation Dec 1, 2023
@david-waltermire david-waltermire moved this from 📋 Backlog to 🔖 Ready in FedRAMP Automation Dec 5, 2023
@david-waltermire david-waltermire moved this from 🔖 Ready to 🏗 In progress in FedRAMP Automation Dec 5, 2023
@david-waltermire david-waltermire self-assigned this Dec 5, 2023
@david-waltermire
Copy link
Member

This was discussed on the 12/6/2023 FedRAMP Early Adopters Workgroup call.

On the call, the FedRAMP PMO recommended that the OSCAL syntax be kept as-is and that the discrepancy be explained in the associated OSCAL documentation. There was general agreement that leaving it as-is was the right thing to do. There were no concerns raised with this way forward on the call.

Based on the discussion result, this issue can be closed. This relates OSCAL issues usnistgov/OSCAL#1618 and usnistgov/OSCAL#1956. usnistgov/OSCAL#1956 can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants