From 0e33c1e879c12026b744c9ad046cd56c4996dc5c Mon Sep 17 00:00:00 2001
From: Gabeblis <gabriel.rodriguez@gsa.gov>
Date: Mon, 30 Dec 2024 15:07:45 +0000
Subject: [PATCH] Add issue-1032 constraints and tests

---
 features/fedramp_extensions.feature           |  6 +++++
 .../ssp/xml/fedramp-ssp-example.oscal.xml     |  9 ++++++++
 ...mponent-has-authenticated-scan-INVALID.xml |  8 +++++++
 ...ry-item-has-authenticated-scan-INVALID.xml | 12 ++++++++++
 .../fedramp-external-constraints.xml          | 23 +++++++++++++++++++
 ...component-has-authenticated-scan-FAIL.yaml |  9 ++++++++
 ...component-has-authenticated-scan-PASS.yaml |  9 ++++++++
 ...tory-item-has-authenticated-scan-FAIL.yaml |  9 ++++++++
 ...tory-item-has-authenticated-scan-PASS.yaml |  9 ++++++++
 9 files changed, 94 insertions(+)
 create mode 100644 src/validations/constraints/content/ssp-component-has-authenticated-scan-INVALID.xml
 create mode 100644 src/validations/constraints/content/ssp-inventory-item-has-authenticated-scan-INVALID.xml
 create mode 100644 src/validations/constraints/unit-tests/component-has-authenticated-scan-FAIL.yaml
 create mode 100644 src/validations/constraints/unit-tests/component-has-authenticated-scan-PASS.yaml
 create mode 100644 src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-FAIL.yaml
 create mode 100644 src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-PASS.yaml

diff --git a/features/fedramp_extensions.feature b/features/fedramp_extensions.feature
index d74753c1d..98a810851 100644
--- a/features/fedramp_extensions.feature
+++ b/features/fedramp_extensions.feature
@@ -36,6 +36,7 @@ Examples:
   | cia-impact-has-adjustment-justification |
   | cia-impact-has-selected |
   | cloud-service-model |
+  | component-has-authenticated-scan |
   | component-has-authentication-method |
   | component-has-non-provider-responsible-role |
   | component-has-provider-responsible-role |
@@ -115,6 +116,7 @@ Examples:
   | interconnection-direction |
   | interconnection-security |
   | inventory-item-allows-authenticated-scan |
+  | inventory-item-has-authenticated-scan |
   | inventory-item-public |
   | inventory-item-virtual |
   | last-accessed-is-datetime |
@@ -197,6 +199,8 @@ Examples:
   | cia-impact-has-selected-PASS.yaml |
   | cloud-service-model-FAIL.yaml |
   | cloud-service-model-PASS.yaml |
+  | component-has-authenticated-scan-FAIL.yaml |
+  | component-has-authenticated-scan-PASS.yaml |
   | component-has-authentication-method-FAIL.yaml |
   | component-has-authentication-method-PASS.yaml |
   | component-has-non-provider-responsible-role-FAIL.yaml |
@@ -355,6 +359,8 @@ Examples:
   | interconnection-security-PASS.yaml |
   | inventory-item-allows-authenticated-scan-FAIL.yaml |
   | inventory-item-allows-authenticated-scan-PASS.yaml |
+  | inventory-item-has-authenticated-scan-FAIL.yaml |
+  | inventory-item-has-authenticated-scan-PASS.yaml |
   | inventory-item-public-FAIL.yaml |
   | inventory-item-public-PASS.yaml |
   | inventory-item-virtual-FAIL.yaml |
diff --git a/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml b/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
index 94b884867..c9e7e19ea 100644
--- a/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+++ b/src/content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
@@ -1518,6 +1518,7 @@ leveraged-authorization assembly:</p>
       </description>
 
       <prop name="implementation-point" value="internal"/>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <prop name="connection-security" value="tls-1.3" ns="http://fedramp.gov/ns/oscal"/>
       <prop ns="http://fedramp.gov/ns/oscal" name="provider" value="self"/>
       <prop ns="http://fedramp.gov/ns/oscal" name="direction" value="outgoing"/>
@@ -1649,6 +1650,7 @@ property.</p>
         <p>Describe the service and what it is used for.</p>
       </description>
       <prop name="implementation-point" value="internal"/>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <status state="operational"/>
     </component>
 
@@ -2353,6 +2355,7 @@ preferable to the link[rel='validation'] example above.</p>
       <!-- Todo: check why schematron validation is indicating that this is not a valid ipv4 value -->
       <prop name="ipv6-address" value="0000:0000:0000:0000:0000:ffff:0a03:0303"/>
       <prop name="is-scanned" value="yes"/>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <prop ns="http://fedramp.gov/ns/oscal" name="scan-type" value="infrastructure"/>
       <implemented-component component-uuid="11111111-2222-4000-8000-009000000008"/>
     </inventory-item>
@@ -2367,6 +2370,7 @@ preferable to the link[rel='validation'] example above.</p>
       <prop name="ipv4-address" value="10.4.4.4"/>
       <prop name="ipv6-address" value="0000:0000:0000:0000:0000:ffff:0a04:0404"/>
       <prop name="is-scanned" value="yes"/>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <prop ns="http://fedramp.gov/ns/oscal" name="scan-type" value="infrastructure"/>
       <implemented-component component-uuid="11111111-2222-4000-8000-009000000007"/>
     </inventory-item>
@@ -2381,6 +2385,7 @@ preferable to the link[rel='validation'] example above.</p>
       <prop name="virtual" value="no"/>
       <prop name="public" value="yes"/>
       <prop name="is-scanned" value="yes"/>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <prop ns="http://fedramp.gov/ns/oscal" name="scan-type" value="infrastructure"/>
       <implemented-component component-uuid="11111111-2222-4000-8000-009000000011"/>
     </inventory-item>
@@ -2399,6 +2404,7 @@ preferable to the link[rel='validation'] example above.</p>
           <p>Asset wasn't running at time of scan.</p>
         </remarks>
       </prop>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <implemented-component component-uuid="11111111-2222-4000-8000-009000000007"/>
     </inventory-item>
     <inventory-item uuid="11111111-2222-4000-8000-011000000007">
@@ -2412,6 +2418,7 @@ preferable to the link[rel='validation'] example above.</p>
       <prop name="virtual" value="no"/>
       <prop name="public" value="no"/>
       <prop name="is-scanned" value="yes"/>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <prop ns="http://fedramp.gov/ns/oscal" name="scan-type" value="infrastructure"/>
       <implemented-component component-uuid="11111111-2222-4000-8000-009000000008"/>
     </inventory-item>
@@ -2430,6 +2437,7 @@ preferable to the link[rel='validation'] example above.</p>
           <p>Asset wasn't running at time of scan.</p>
         </remarks>
       </prop>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <implemented-component component-uuid="11111111-2222-4000-8000-009000000007"/>
     </inventory-item>
     <inventory-item uuid="11111111-2222-4000-8000-011000000009">
@@ -2443,6 +2451,7 @@ preferable to the link[rel='validation'] example above.</p>
       <prop name="virtual" value="yes"/>
       <prop name="public" value="no"/>
       <prop name="is-scanned" value="yes"/>
+      <prop name="allows-authenticated-scan" value="yes"/>
       <prop ns="http://fedramp.gov/ns/oscal" name="scan-type" value="infrastructure"/>
       <implemented-component component-uuid="11111111-2222-4000-8000-009000000018"/>
     </inventory-item>
diff --git a/src/validations/constraints/content/ssp-component-has-authenticated-scan-INVALID.xml b/src/validations/constraints/content/ssp-component-has-authenticated-scan-INVALID.xml
new file mode 100644
index 000000000..d831bef9c
--- /dev/null
+++ b/src/validations/constraints/content/ssp-component-has-authenticated-scan-INVALID.xml
@@ -0,0 +1,8 @@
+<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
+  <system-implementation>
+    <component uuid="11111111-2222-4000-8000-009000500004" type="service">
+      <!-- <prop name="allows-authenticated-scan" value="yes"/> Missing allows-authenticated-scan prop. -->
+      <prop name="implementation-point" value="internal"/>
+    </component>
+  </system-implementation>
+</system-security-plan>
\ No newline at end of file
diff --git a/src/validations/constraints/content/ssp-inventory-item-has-authenticated-scan-INVALID.xml b/src/validations/constraints/content/ssp-inventory-item-has-authenticated-scan-INVALID.xml
new file mode 100644
index 000000000..8f5a1b05c
--- /dev/null
+++ b/src/validations/constraints/content/ssp-inventory-item-has-authenticated-scan-INVALID.xml
@@ -0,0 +1,12 @@
+<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
+  <system-implementation>
+    <component type="service" uuid="11111111-2222-4000-8000-009000000007">
+      <!-- <prop name="allows-authenticated-scan" value="yes"/> Missing allows-authenticated-scan prop. -->
+    </component>
+    <inventory-item uuid="11111111-2222-4000-8000-011000000001">
+      <!-- <prop name="allows-authenticated-scan" value="yes"/> Missing allows-authenticated-scan prop. -->
+      <implemented-component component-uuid="11111111-2222-4000-8000-009000000007">
+      </implemented-component>
+    </inventory-item>
+  </system-implementation>
+</system-security-plan>
\ No newline at end of file
diff --git a/src/validations/constraints/fedramp-external-constraints.xml b/src/validations/constraints/fedramp-external-constraints.xml
index 1f1d2cc54..e4a368ffc 100644
--- a/src/validations/constraints/fedramp-external-constraints.xml
+++ b/src/validations/constraints/fedramp-external-constraints.xml
@@ -637,6 +637,29 @@
         </constraints>
     </context>
 
+    <context>
+        <metapath target="/system-security-plan/system-implementation/component"/>
+        <constraints>
+            <expect id="component-has-authenticated-scan" target=".[@type='service' and prop[@name='implementation-point' and @value='internal']]" test="count(prop[@name='allows-authenticated-scan']) = 1" level="ERROR">
+                <formal-name>Component Has Authenticated Scan</formal-name>
+                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
+                <message>In a FedRAMP SSP, each internal service component MUST state whether it allows authenticated scans.</message>
+            </expect>
+        </constraints>
+    </context>
+
+    <context>
+        <metapath target="/system-security-plan/system-implementation/inventory-item"/>
+        <constraints>
+            <let var ="component-uuid" expression="implemented-component/@component-uuid"/>
+            <expect id="inventory-item-has-authenticated-scan" target="." test="count(prop[@name='allows-authenticated-scan']) >= 1 or count(../component[@uuid=$component-uuid]/prop[@name='allows-authenticated-scan']) = 1" level="ERROR">
+                <formal-name>Inventory Item Has Authenticated Scan</formal-name>
+                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
+                <message>In a FedRAMP SSP, each inventory item MUST state whether it allows authenticated scans in the inventory item itself or within the linked component.</message>
+            </expect>
+        </constraints>
+    </context>
+
     <context>
         <metapath target="/(assessment-plan|assessment-results|plan-of-action-and-milestones|system-security-plan)/metadata"/>
         <constraints>
diff --git a/src/validations/constraints/unit-tests/component-has-authenticated-scan-FAIL.yaml b/src/validations/constraints/unit-tests/component-has-authenticated-scan-FAIL.yaml
new file mode 100644
index 000000000..9640ee3c6
--- /dev/null
+++ b/src/validations/constraints/unit-tests/component-has-authenticated-scan-FAIL.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Negative Test for component-has-authenticated-scan
+  description: >-
+    This test case validates the behavior of constraint
+    component-has-authenticated-scan
+  content: ../content/ssp-component-has-authenticated-scan-INVALID.xml
+  expectations:
+    - constraint-id: component-has-authenticated-scan
+      result: fail
diff --git a/src/validations/constraints/unit-tests/component-has-authenticated-scan-PASS.yaml b/src/validations/constraints/unit-tests/component-has-authenticated-scan-PASS.yaml
new file mode 100644
index 000000000..489f96149
--- /dev/null
+++ b/src/validations/constraints/unit-tests/component-has-authenticated-scan-PASS.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Positive Test for component-has-authenticated-scan
+  description: >-
+    This test case validates the behavior of constraint
+    component-has-authenticated-scan
+  content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+  expectations:
+    - constraint-id: component-has-authenticated-scan
+      result: pass
diff --git a/src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-FAIL.yaml b/src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-FAIL.yaml
new file mode 100644
index 000000000..218802efc
--- /dev/null
+++ b/src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-FAIL.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Negative Test for inventory-item-has-authenticated-scan
+  description: >-
+    This test case validates the behavior of constraint
+    inventory-item-has-authenticated-scan
+  content: ../content/ssp-inventory-item-has-authenticated-scan-INVALID.xml
+  expectations:
+    - constraint-id: inventory-item-has-authenticated-scan
+      result: fail
diff --git a/src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-PASS.yaml b/src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-PASS.yaml
new file mode 100644
index 000000000..13a912a94
--- /dev/null
+++ b/src/validations/constraints/unit-tests/inventory-item-has-authenticated-scan-PASS.yaml
@@ -0,0 +1,9 @@
+test-case:
+  name: Positive Test for inventory-item-has-authenticated-scan
+  description: >-
+    This test case validates the behavior of constraint
+    inventory-item-has-authenticated-scan
+  content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
+  expectations:
+    - constraint-id: inventory-item-has-authenticated-scan
+      result: pass