Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval Form - Save button implementation #167

Closed
11 of 12 tasks
Tracked by #61
stepchud opened this issue Sep 13, 2024 · 3 comments
Closed
11 of 12 tasks
Tracked by #61

Eval Form - Save button implementation #167

stepchud opened this issue Sep 13, 2024 · 3 comments
Assignees
Labels

Comments

@stepchud
Copy link
Contributor

stepchud commented Sep 13, 2024

What/Why

This task will enable the user to Save a valid evaluation form.
It must be completed after (is blocked by) #162, #163

Acceptance Criteria

  • Save validates all form fields
    • Form start_date is automatically set to the Challenge Phase phase.end_date
    • Form end_date must be after the Form start_date
    • Form end_date is always editable
    • Total of all Criteria for Weighted Scoring must add up to 100
    • When the evaluation period starts, form fields are not editable (except end_date)
  • If the form passes validation it is persisted to the DB
  • If the form passes validation, the confirmation page is displayed to the user

Disregard the following if this work does not include any UI changes

  • WAVE screenshot
  • Automated a11y tests (axe-rspec specs)
  • Keyboard accessibility (tab navigation, form interactions)
  • Responsiveness at desktop and mobile

Out of Scope

@stepchud stepchud changed the title Eval forms Save & Publish button implementation Eval Form - Save & Publish button implementation Sep 13, 2024
@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Sep 19, 2024

@stepchud

Suggested rewrite of the AC:

  • 'Save' validates all form fields
  • Evaluation start date is Challenge close date
  • Evaluation end date is after start date
  • Evaluation end date is always editable
  • Total of all Criteria for Weighted Scoring must add up to 100
  • If the form passes validation a confirmation page is displayed
  • The form fields, expect end date, are not editable between evaluation period dates

@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 10/08/24 milestone Sep 25, 2024
@stepchud stepchud changed the title Eval Form - Save & Publish button implementation Eval Form - Save button implementation Oct 4, 2024
@stonefilipczak stonefilipczak self-assigned this Oct 8, 2024
@cpreisinger
Copy link
Contributor

Screenshot 2024-10-31 at 4 08 02 PM

@stepchud
Copy link
Contributor Author

stepchud commented Nov 1, 2024

Fixed in #219

@stepchud stepchud closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants