Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HTTPoison Card #1445 #1570

Merged
merged 16 commits into from
Feb 20, 2025
Merged

Replace HTTPoison Card #1445 #1570

merged 16 commits into from
Feb 20, 2025

Conversation

jdonis
Copy link
Contributor

@jdonis jdonis commented Feb 20, 2025 •
edited
Loading

Description

Replace Finch with HTTPoison

Related Issues

[Reference any related issues, if applicable.]

Changes Made

  • Remove Finch from mix.exs
  • Updated calls (POST, GET, DELETE)
  • Updated seed file importer

Screenshots (if applicable)

[Include screenshots to visually demonstrate changes, if relevant.]

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.
  • Build has been approved for deployment in CircleCI.

jairoanaya and others added 16 commits February 8, 2025 11:33
@jairoanaya
1491 - add banner API and fix unnecesary format on banner
e53c444
@jairoanaya
Fix lint issue
9efd495
@kkrug
Merge branch 'staging' into 1491-site-wide-banner
f3bf12e
@kkrug
Merge pull request #1558 from GSA/1491-site-wide-banner
6c0ffaf 
1491 - add banner API and fix unnecesary format on banner
@jairoanaya
Adding test for side wine banner API
9a6099d
@kkrug
Merge branch 'staging' into 1491-site-wide-banner
2d24684
@kkrug
Merge pull request #1561 from GSA/1491-site-wide-banner
3e6f16f 
Adding test for side wine banner API
@jairoanaya
Merge pull request #1562 from GSA/staging
59e7702 
Staging to Prod
@jairoanaya
Fix issue wiht follow button
a1e14ba
@kkrug
Merge pull request #1565 from GSA/1560-invalid-follow-challenge-url
de69435 
Fix issue wiht follow button
@kkrug
Merge branch 'production' into staging
8f0c88b
@jdonis
Remove Finch and replace with Httpoison
6555763
@jdonis
Update deps
a66bc12
@jdonis
mix.lock & logger
46af91d
@jdonis
elixir version
9cc3bad
@jdonis
Merge & solved conflicts to replace finch
328ae7a
@jdonis jdonis requested review from jairoanaya and kkrug February 20, 2025 13:14
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 02/25/25 milestone Feb 20, 2025
@r-bartlett-gsa r-bartlett-gsa linked an issue Feb 20, 2025 that may be closed by this pull request
Update external traffic calls to use the egress proxy #1445
Open
4 tasks
@kkrug kkrug merged commit d834e02 into dev Feb 20, 2025
6 checks passed
@kkrug kkrug deleted the dev-with-httpoison-1445 branch February 20, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrug kkrug kkrug approved these changes

@jairoanaya jairoanaya Awaiting requested review from jairoanaya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 02/25/25
Development

Successfully merging this pull request may close these issues.

Update external traffic calls to use the egress proxy
4 participants
@jdonis @kkrug @r-bartlett-gsa @jairoanaya