Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SectionObserver problem with About Us Section #84

Open
1 of 2 tasks
pareshlamichhane opened this issue Dec 14, 2024 · 2 comments
Open
1 of 2 tasks

[Bug]: SectionObserver problem with About Us Section #84

pareshlamichhane opened this issue Dec 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@pareshlamichhane
Copy link

pareshlamichhane commented Dec 14, 2024

📜 Description

When display of resolution 1366x720, visits the website, the is a simple mistake in Navigation bar.
It wont register the page is already scrolled into about us section.
I found the cause of it, most likely, the main problem here is the size of About Us section.

In the Observer.jsx component, the threshold is set to 0.8 which means when 80% of the content of about us is focused in the screen, only it registers it as active in the navigation menu. But since the sheer size of About Us section is bigger, in screen of resolution 1366x720, it wont ever conver the 80% of the about section at a time.

To prove my hypothesis, I zoomed out the website to 67% and the the bug wouldn't work in this condition.

👟 Reproduction steps

  1. Get a display of 1366x720 resolution.
  2. Open the website nepal.gnome.org or gnomenepal.netlify.app
  3. Scroll down
  4. You will see About Us isn't being registered as active in the navigation menu

👍 Expected behavior

While scrolling the website About Us should have been registered as active in the navigation menu

👎 Actual Behavior with Screenshots

  • 100% Zoom in 1366x720 resoultion display
    image

  • 67% Zoom in 1366x720 resoultion display
    image

💻 Operating system

Linux

What browsers are you seeing the problem on?

Chrome

📃 Provide any additional context for the Bug.

No response

📖 Relevant log output

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🔗 Are you willing to submit PR?

None

🧑‍⚖️ Code of Conduct

  • I agree to follow this project's Code of Conduct
@pareshlamichhane pareshlamichhane added the bug Something isn't working label Dec 14, 2024
@utsavdotdev
Copy link
Collaborator

Hi @pareshlamichhane, Thanks for noticing this bug. Can you resolved it?

@pareshlamichhane
Copy link
Author

Hi @pareshlamichhane, Thanks for noticing this bug. Can you resolved it?

I am a bit involved in courseworks, so I think its better to give this role to somebody else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants