Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "attributes" aspect #3293

Open
tclune opened this issue Jan 8, 2025 · 0 comments
Open

Implement "attributes" aspect #3293

tclune opened this issue Jan 8, 2025 · 0 comments
Assignees
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Jan 8, 2025

As with the other aspects (Geom,VerticalGrid,Units,...) we need as aspect for "attributes". Here there is no action to provide, but the aspect provides he rules by which "shared" attributes match. (Basically, the dst shared attributes must be a subset of the dest attributes.)

There are a couple of aux things that could be split into separate tickets.

  1. I think the existing check on attributes preceded the work that implemented a proper namespace on shared attributes. That should be re-examined and updated.
  2. We need to add logic to couplers to propagate shared attributes during the initialization step (We don't allow attributes to be time dependent - at least for now.
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Development

No branches or pull requests

2 participants